AdminAuthorizationHelperTests.js 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431
  1. const { expect } = require('chai')
  2. const SandboxedModule = require('sandboxed-module')
  3. const sinon = require('sinon')
  4. const MockRequest = require('../helpers/MockRequest')
  5. const MockResponse = require('../helpers/MockResponse')
  6. const modulePath =
  7. '../../../../app/src/Features/Helpers/AdminAuthorizationHelper'
  8. describe('AdminAuthorizationHelper', function () {
  9. beforeEach(function () {
  10. this.fireHook = sinon.stub().resolves([])
  11. this.AdminAuthorizationHelper = SandboxedModule.require(modulePath, {
  12. requires: {
  13. '@overleaf/settings': {
  14. adminPrivilegeAvailable: true,
  15. adminUrl: 'https://admin.overleaf.com',
  16. },
  17. '../../infrastructure/Modules': {
  18. promises: {
  19. hooks: {
  20. fire: this.fireHook,
  21. },
  22. },
  23. },
  24. },
  25. })
  26. })
  27. describe('getAdminCapabilities', function () {
  28. describe('when modules return capabilities', function () {
  29. let result
  30. const module1Capabilities = ['capability1', 'capability2']
  31. const module2Capabilities = ['capability2', 'capability3']
  32. beforeEach(async function () {
  33. this.fireHook.resolves([module1Capabilities, module2Capabilities])
  34. result = await this.AdminAuthorizationHelper.getAdminCapabilities({})
  35. })
  36. it('returns true for adminCapabilitiesAvailable', async function () {
  37. expect(result.adminCapabilitiesAvailable).to.be.true
  38. })
  39. it('returns a flattened array of the returned capabilities', function () {
  40. expect(result.adminCapabilities)
  41. .to.be.an('array')
  42. .that.includes(...module1Capabilities, ...module2Capabilities)
  43. })
  44. })
  45. describe('when no module returns capabilities', function () {
  46. let result
  47. beforeEach(async function () {
  48. result = await this.AdminAuthorizationHelper.getAdminCapabilities({})
  49. })
  50. it('returns false for adminCapabilitiesAvailable', function () {
  51. expect(result.adminCapabilitiesAvailable).to.be.false
  52. })
  53. it('returns an empty adminCapabilities array', function () {
  54. expect(result.adminCapabilities).to.be.an('array').that.is.empty
  55. })
  56. })
  57. })
  58. describe('useAdminCapabilities', function () {
  59. describe('when admin capabilities are not available', function () {
  60. describe('user is null', function () {
  61. beforeEach(async function () {
  62. this.req = new MockRequest()
  63. this.res = new MockResponse()
  64. this.next = sinon.stub()
  65. this.req.session = {
  66. user: null,
  67. }
  68. await this.AdminAuthorizationHelper.useAdminCapabilities(
  69. this.req,
  70. this.res,
  71. this.next
  72. )
  73. })
  74. it('does not define adminCapabilitiesAvailable on req', function () {
  75. expect(this.req).not.to.have.property('adminCapabilitiesAvailable')
  76. })
  77. it('defines adminCapabilities as an empty array on req', function () {
  78. expect(this.req).to.have.property('adminCapabilities')
  79. expect(this.req.adminCapabilities).to.be.an('array')
  80. expect(this.req.adminCapabilities).to.be.empty
  81. })
  82. })
  83. describe('user is not an admin', function () {
  84. beforeEach(async function () {
  85. this.req = new MockRequest()
  86. this.res = new MockResponse()
  87. this.next = sinon.stub()
  88. this.user = {
  89. isAdmin: false,
  90. }
  91. this.req.session = {
  92. user: this.user,
  93. }
  94. await this.AdminAuthorizationHelper.useAdminCapabilities(
  95. this.req,
  96. this.res,
  97. this.next
  98. )
  99. })
  100. it('does not define adminCapabilitiesAvailable on req', function () {
  101. expect(this.req).not.to.have.property('adminCapabilitiesAvailable')
  102. })
  103. it('defines adminCapabilities as an empty array on req', function () {
  104. expect(this.req).to.have.property('adminCapabilities')
  105. expect(this.req.adminCapabilities).to.be.an('array')
  106. expect(this.req.adminCapabilities).to.be.empty
  107. })
  108. })
  109. describe('user is an admin', function () {
  110. beforeEach(async function () {
  111. this.req = new MockRequest()
  112. this.res = new MockResponse()
  113. this.next = sinon.stub()
  114. this.user = {
  115. isAdmin: true,
  116. }
  117. this.req.session = {
  118. user: this.user,
  119. }
  120. await this.AdminAuthorizationHelper.useAdminCapabilities(
  121. this.req,
  122. this.res,
  123. this.next
  124. )
  125. })
  126. it('defines adminCapabilitiesAvailable as false on req', function () {
  127. expect(this.req).to.have.property('adminCapabilitiesAvailable', false)
  128. })
  129. it('defines adminCapabilities as an empty array', function () {
  130. expect(this.req).to.have.property('adminCapabilities')
  131. expect(this.req.adminCapabilities).to.be.an('array')
  132. expect(this.req.adminCapabilities).to.be.empty
  133. })
  134. })
  135. })
  136. describe('when admin capabilities are available', function () {
  137. beforeEach(function () {
  138. this.fireHook.resolves(['capability1', 'capability2'])
  139. })
  140. describe('user is not an admin', function () {
  141. beforeEach(async function () {
  142. this.req = new MockRequest()
  143. this.res = new MockResponse()
  144. this.next = sinon.stub()
  145. this.user = {
  146. isAdmin: false,
  147. }
  148. this.req.session = {
  149. user: this.user,
  150. }
  151. await this.AdminAuthorizationHelper.useAdminCapabilities(
  152. this.req,
  153. this.res,
  154. this.next
  155. )
  156. })
  157. it('does not define adminCapabilitiesAvailable on req', function () {
  158. expect(this.req).not.to.have.property('adminCapabilitiesAvailable')
  159. })
  160. it('defines adminCapabilities as an empty array on req', function () {
  161. expect(this.req).to.have.property('adminCapabilities')
  162. expect(this.req.adminCapabilities).to.be.an('array')
  163. expect(this.req.adminCapabilities).to.be.empty
  164. })
  165. })
  166. describe('user is an admin', function () {
  167. beforeEach(async function () {
  168. this.req = new MockRequest()
  169. this.res = new MockResponse()
  170. this.next = sinon.stub()
  171. this.user = {
  172. isAdmin: true,
  173. }
  174. this.req.session = {
  175. user: this.user,
  176. }
  177. await this.AdminAuthorizationHelper.useAdminCapabilities(
  178. this.req,
  179. this.res,
  180. this.next
  181. )
  182. })
  183. it('defines adminCapabilitiesAvailable as true on req', function () {
  184. expect(this.req).to.have.property('adminCapabilitiesAvailable', true)
  185. })
  186. it('defines adminCapabilities with the capabilities returned from modules', function () {
  187. expect(this.req).to.have.property('adminCapabilities')
  188. expect(this.req.adminCapabilities).to.be.an('array')
  189. expect(this.req.adminCapabilities).to.include('capability1')
  190. expect(this.req.adminCapabilities).to.include('capability2')
  191. })
  192. })
  193. })
  194. describe('when getting capabilities from modules throws an error', function () {
  195. beforeEach(async function () {
  196. this.fireHook.rejects(new Error('Module error'))
  197. this.req = new MockRequest()
  198. this.res = new MockResponse()
  199. this.next = sinon.stub()
  200. this.user = {
  201. isAdmin: true,
  202. }
  203. this.req.logger = {
  204. warn: sinon.stub(),
  205. }
  206. this.req.session = {
  207. user: this.user,
  208. }
  209. await this.AdminAuthorizationHelper.useAdminCapabilities(
  210. this.req,
  211. this.res,
  212. this.next
  213. )
  214. })
  215. it('logs the error', function () {
  216. expect(this.logger.warn).to.have.been.calledWith(
  217. sinon.match.has('err', sinon.match.instanceOf(Error))
  218. )
  219. })
  220. it('defines adminCapabilitiesAvailable as true on req', function () {
  221. expect(this.req).to.have.property('adminCapabilitiesAvailable', true)
  222. })
  223. it('defines adminCapabilities as an empty array', function () {
  224. expect(this.req).to.have.property('adminCapabilities')
  225. expect(this.req.adminCapabilities).to.be.an('array')
  226. expect(this.req.adminCapabilities).to.be.empty
  227. })
  228. })
  229. })
  230. describe('useHasAdminCapability', function () {
  231. it('adds hasAdminCapability to res.locals', function () {
  232. const req = new MockRequest()
  233. const res = new MockResponse()
  234. const next = sinon.stub()
  235. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  236. expect(res.locals).to.have.property('hasAdminCapability')
  237. expect(res.locals.hasAdminCapability).to.be.a('function')
  238. })
  239. describe('when the user is not an admin', function () {
  240. describe('when req.adminCapabilitiesAvailable is true', function () {
  241. it('returns false for any capability', function () {
  242. const req = new MockRequest()
  243. const res = new MockResponse()
  244. const next = sinon.stub()
  245. req.adminCapabilitiesAvailable = true
  246. req.adminCapabilities = []
  247. req.session.user = { isAdmin: false }
  248. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  249. expect(res.locals.hasAdminCapability('capability1')).to.be.false
  250. })
  251. })
  252. describe('when req.adminCapabilitiesAvailable is false', function () {
  253. it('returns false for any capability', function () {
  254. const req = new MockRequest()
  255. const res = new MockResponse()
  256. const next = sinon.stub()
  257. req.adminCapabilitiesAvailable = false
  258. req.adminCapabilities = []
  259. req.session.user = { isAdmin: false }
  260. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  261. expect(res.locals.hasAdminCapability('capability1')).to.be.false
  262. })
  263. })
  264. describe('when req.adminCapabilitiesAvailable is undefined', function () {
  265. it('returns false for any capability', function () {
  266. const req = new MockRequest()
  267. const res = new MockResponse()
  268. const next = sinon.stub()
  269. req.session.user = { isAdmin: false }
  270. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  271. expect(res.locals.hasAdminCapability('capability1')).to.be.false
  272. })
  273. })
  274. })
  275. describe('user is an admin', function () {
  276. describe('when req.adminCapabilitiesAvailable is false', function () {
  277. it('returns true for any capability', function () {
  278. const req = new MockRequest()
  279. const res = new MockResponse()
  280. const next = sinon.stub()
  281. req.session.user = { isAdmin: true }
  282. req.adminCapabilitiesAvailable = false
  283. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  284. expect(res.locals.hasAdminCapability('capability1')).to.be.true
  285. })
  286. })
  287. describe('when req.adminCapabilitiesAvailable is undefined', function () {
  288. it('returns true for any capability', function () {
  289. const req = new MockRequest()
  290. const res = new MockResponse()
  291. const next = sinon.stub()
  292. req.session.user = { isAdmin: true }
  293. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  294. expect(res.locals.hasAdminCapability('capability1')).to.be.true
  295. })
  296. })
  297. describe('when req.adminCapabilitiesAvailable is true', function () {
  298. let req, res, next
  299. beforeEach(function () {
  300. req = new MockRequest()
  301. res = new MockResponse()
  302. next = sinon.stub()
  303. req.session.user = { isAdmin: true }
  304. req.adminCapabilitiesAvailable = true
  305. req.adminCapabilities = ['capability1', 'capability2']
  306. this.AdminAuthorizationHelper.useHasAdminCapability(req, res, next)
  307. })
  308. it('returns true for a capability the user has', function () {
  309. expect(res.locals.hasAdminCapability('capability1')).to.be.true
  310. })
  311. it('returns false for a capability the user does not have', function () {
  312. expect(res.locals.hasAdminCapability('capability3')).to.be.false
  313. })
  314. })
  315. })
  316. })
  317. describe('hasAdminCapability', function () {
  318. describe('when user is not an admin', function () {
  319. it('returns false', function () {
  320. const req = {
  321. session: {
  322. user: { isAdmin: false },
  323. },
  324. }
  325. expect(
  326. this.AdminAuthorizationHelper.hasAdminCapability('capability')(req)
  327. ).to.be.false
  328. })
  329. })
  330. describe('when user is an admin', function () {
  331. describe('when adminCapabilitiesAvailable is falsey', function () {
  332. it('returns true', function () {
  333. const req = {
  334. session: {
  335. user: { isAdmin: true },
  336. },
  337. adminCapabilitiesAvailable: false,
  338. }
  339. expect(
  340. this.AdminAuthorizationHelper.hasAdminCapability('capability')(req)
  341. ).to.be.true
  342. })
  343. })
  344. describe('when adminCapabilitiesAvailable is true', function () {
  345. describe('when user has the requested capability', function () {
  346. it('returns true', function () {
  347. const req = {
  348. session: { user: { isAdmin: true } },
  349. adminCapabilitiesAvailable: true,
  350. adminCapabilities: ['capability'],
  351. }
  352. expect(
  353. this.AdminAuthorizationHelper.hasAdminCapability('capability')(
  354. req
  355. )
  356. ).to.be.true
  357. })
  358. })
  359. describe('when user does not have the requested capability', function () {
  360. it('returns false', function () {
  361. const req = {
  362. session: { user: { isAdmin: true } },
  363. adminCapabilitiesAvailable: true,
  364. adminCapabilities: ['other-capability'],
  365. }
  366. expect(
  367. this.AdminAuthorizationHelper.hasAdminCapability('capability')(
  368. req
  369. )
  370. ).to.be.false
  371. })
  372. })
  373. })
  374. })
  375. })
  376. })